amTimeAgo pipe updates it's output when locale changes #188
+26
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeAgoPipe
updates it's output only when it detects it's input has changed.To do so, it does extract and compare a timestamp (milliseconds).
The output, however, depends not only on milliseconds, but also on locale. That was not taken into account.
I hereby propose a pull request that fixes this.
Locale setting for current moment instance is now considered. If you change locale globally (
moment.locale(...)
) you will need to make sure new moment instance will trigger the pipe. I consider this the most predictable behaviour.Please let me know your view, or suggest further changes. Thank you!
Resolves #172.